Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI doesn't let you select the 1x playback rate when the video element's default playback rate is not 1x #7757

Closed
absidue opened this issue Dec 12, 2024 · 0 comments · Fixed by #7787
Assignees
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@absidue
Copy link

absidue commented Dec 12, 2024

Have you read the FAQ and checked for duplicate open issues?

Yes

If the problem is related to FairPlay, have you read the tutorial?

Not applicable

What version of Shaka Player are you using?

4.11.4

Can you reproduce the issue with our latest release version?

Yes

Can you reproduce the issue with the latest code from main?

Yes, nightly demo

Are you using the demo app or your own custom app?

Both

If custom app, can you reproduce the issue using our demo app?

Yes

What browser and OS are you using?

Firefox, Windows 10

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

Not applicable

What are the manifest and license server URIs?

Any will work as this is a UI bug.

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

Default

What did you do?

  1. Open the nightly demo page
  2. Run document.querySelector('video').defaultPlaybackRate = 1.5; document.querySelector('video').playbackRate = 1.5 in the dev tools
  3. Click on any of the test assets
  4. Try selecting 1x in the playback rate menu

What did you expect to happen?

It to switch to 1x and the UI to update to reflect that.

What actually happened?

It stayed at 1.5x, other playback rates can still be selected from the playback rate menu, only 1x is the problem.

Are you planning send a PR to fix it?

No, as I'm not sure what the best solution is other than reverting the PR that is causing all of these issues: #7580

Similar bug reports: #7724, #7756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants