Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback rate resets when pausing or playing the video #7724

Closed
absidue opened this issue Dec 6, 2024 · 2 comments · Fixed by #7728
Closed

Playback rate resets when pausing or playing the video #7724

absidue opened this issue Dec 6, 2024 · 2 comments · Fixed by #7728
Assignees
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@absidue
Copy link

absidue commented Dec 6, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Not applicable

What version of Shaka Player are you using?

4.12.4

Can you reproduce the issue with our latest release version?

Yes

Can you reproduce the issue with the latest code from main?

Yes (nightly demo page)

Are you using the demo app or your own custom app?

Both

If custom app, can you reproduce the issue using our demo app?

Yes

What browser and OS are you using?

Firefox on Windows 10

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

Not applicable

What are the manifest and license server URIs?

Any will work as this is a UI bug

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

Default

What did you do?

  1. Open any video in the demo player
  2. Change the playback rate through the UI
  3. Pause the video

What did you expect to happen?

The playback rate should stay at the configured rate

What actually happened?

The playback rate was reset to 1x. Another issue is that if you change the playback rate while the video is paused, it will automatically start playing as soon as you select a playback rate.

Are you planning send a PR to fix it?

I'm not sure what the right solution to this problem is, from my testing the problem was introduced in 4.12.1, as 4.12.0 works correctly and later releases, as well as the nightly demo have the same issue. The only pull request that changed code concerning the playback rate in 4.12.1 was #7580 so that is likely to be the culprit.

@absidue absidue added the type: bug Something isn't working correctly label Dec 6, 2024
@shaka-bot shaka-bot added this to the v4.13 milestone Dec 6, 2024
@avelad avelad added component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Dec 9, 2024
@avelad avelad self-assigned this Dec 9, 2024
@avelad avelad closed this as completed in 6e382ce Dec 9, 2024
@absidue
Copy link
Author

absidue commented Dec 12, 2024

The second issue about the video starting to play when you select a playback rate instead of staying paused still happens with the nightly demo. Should I open a separate bug report for that? There is also another bug that if you change the defaultPlaybackRate of the video element to something other than 1.0, the UI won't let you select 1x.

@absidue
Copy link
Author

absidue commented Dec 12, 2024

Opened two new issues, one for each of the bugs.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Feb 7, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants