Additional User Input Flags 2 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to disable the prompts for Username and Configuration. Can now disable all user input if desired. If the Configuration prompt is disabled, remove that information from the welcomeMessage variable Re-order the promptFor__ toggles to match the order they appear in the Welcome screen.
attempting to fix a conflict
|
Thanks again, @rougegoat. I'm now observing a Will you please resubmit? |
|
@rougegoat: Actually, will you please give me a few minutes to add some local fixes? |
|
@rougegoat: I just pushed |
Redid the changes against latest Dev build
|
I have rebuilt using rc-23, and that looks to have fixed the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested over in my last PR, here's a new one that adds the option to disable the Username value. I think I held off on that initially because of the possibility of a trailing comma if certain combinations were disabled. I've reworked it a bit to ensure that there won't be trailing comma in any combination of prompts. You should now be able to enable or disable all of the ones on the Welcome page without breaking the next steps.
I also went ahead and made it so that if the Configuration prompt is disabled it also removes mention of configurations from the Welcome text.
I think this will be my last PR before the next official release assuming everything works as expected.