Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional User Input Flags #34

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

rougegoat
Copy link
Contributor

Adjusted previous "promptFor_" toggles to line up with other toggles in the script Add a commented out option to disable Blur screen on production runs Added a handful of Branding overrides

Primary goal is to cut down on modifications needed by those adapting this script down the line.

Adjusted previous "promptFor_" toggles to line up with other toggles in the script
Add a commented out option to disable Blur screen on production runs
Added a handful of Branding overrides

Primary goal is to cut down on modifications needed by those adapting this script down the line.
Centralized IT Support info so that those who are fine with most of the text can insert their info without modifying lower portions of code.
@dan-snelson dan-snelson merged commit 95c1be3 into setup-your-mac:development Apr 24, 2023
@dan-snelson
Copy link
Collaborator

@rougegoat:

First. thanks for all the excellent PRs; long-term, your additions are going to make SYM much more accessible for new Mac Admins.

Second, in testing 1.10.0-rc21, looks like we don't currently have a way to disable User Name:

# These control which user input boxes are added to the first page of Setup Your Mac. If you do not want to ask about a value, set it to any other value
promptForAssetTag="false"
promptForRoom="false"
promptForComputerName="false"
prefillUsername="false"
moveableInProduction="false"

Screenshot 2023-04-24 at 9 27 22 AM

(As an example, for our internal use-case, we only prompt users for Asset Tag and Configuration.)

Please advise if you have cycles to submit (yet) another PR.

Thanks again.

--
Dan

@dan-snelson
Copy link
Collaborator

As a Band-Aid, I've replaced the public 1.10.0-rc21

    "textfield" : [
        {   "title" : "User Name",
            "required" : false,
            "prompt" : "User Name"
            '${usernamePrefil}'
        }
        '${compNameJSON}'
        '${assetTagJSON}'
        '${roomJSON}'
    ],

… with our internal:

    "textfield" : [
        {   "title" : "Asset Tag",
            "required" : true,
            "prompt" : "Please enter the seven-digit Asset Tag",
            "regex" : "^(AP|IP|CD)?[0-9]{7,}$",
            "regexerror" : "Please enter (at least) seven digits for the Asset Tag, optionally preceed by either AP, IP or CD."
        }
    ],

@dan-snelson dan-snelson self-assigned this Apr 28, 2023
@dan-snelson dan-snelson added this to the 1.10.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants