Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport explicit Property Names such as @Excepetion #66

Closed

Conversation

warrenbuckley
Copy link
Contributor

@warrenbuckley warrenbuckley commented Feb 8, 2022

This is to support porting over from Serilog.Filters.Expressions that supported more verbose/explicit names
Fixes #63

@Message
@MessageTemplate
@Level
@Exception
@TimeStamp
@Properties

Note: I have not added more verbose names for Renderings and EventId as these were not present in Serilog.Filters.Expressions.
So I will leave it up to you @nblumhardt if you want to add or support them as well.

@warrenbuckley
Copy link
Contributor Author

Here is my related PR of me porting across from Serilog.Filters.Expressions
Be super cool of you @nblumhardt if you were able to look over these changes to see if there is anythign I have missed or perhaps done wrong.

warrenbuckley/Compact-Log-Format-Viewer#469

@nblumhardt
Copy link
Member

Thanks for the PR, @warrenbuckley!

I had in mind that we'd implement this through NameResolver, rather than add support directly. I'll take a look later today and see if I can come up with a way to do it, and loop back here :-)

I checked out your PR in Compact-Log-Format-Viewer, LGTM.

@warrenbuckley
Copy link
Contributor Author

Hi @nblumhardt
Yes let me know how I should intend to use NameResolver to map properties as needed.

@warrenbuckley
Copy link
Contributor Author

Closing this PR and using PR #65 for discussion

@warrenbuckley warrenbuckley deleted the backport-explicit-propertynames branch February 11, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Porting from Serilog.Filters.Expressions: Missing @Message @MessageTemplate etc
2 participants