Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting from Serilog.Filters.Expressions: Missing @Message @MessageTemplate etc #63

Closed
warrenbuckley opened this issue Feb 7, 2022 · 2 comments · Fixed by #67
Closed

Comments

@warrenbuckley
Copy link
Contributor

warrenbuckley commented Feb 7, 2022

Hi @nblumhardt
I am porting over from Serilog.Filters.Expressions and missing the possibility of expressions using a friendlier name for the built in properties rather than short hand version, as this will break any existing saved search expressions/queries when trying to migrate.

Is it possible to add support for the following:

@TimeStamp
@Level
@Message
@MessageTemplate
@Exception
@Properties['myProp']
@nblumhardt
Copy link
Member

Hi @warrenbuckley!

There's nothing currently, but this has been on my radar for a while. If you're making the port and this is the last blocker, I'm on board with adding support for aliases. Are you reasonably confident that everything else you need for the port is supported?

@warrenbuckley
Copy link
Contributor Author

warrenbuckley commented Feb 8, 2022

Hi @nblumhardt
I have done a PR to add this in to help with the port away from Serilog.Filters.Expressions
Let me know what you think or feel free to edit/work in the same PR as needed

#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants