Auto migrate from old schema by checking autoMigrateOldSchema option #84
Conversation
should return a Promise instance
|
Ready for code review! Hope to be everything as you expected. :) Edit: If you don't mind, i would ask you to warn me on next version release so we can continue our work internally with our sysadmin. :) |
|
Seems that the test i made is intermittent on sqlite dialect. Could you please check what could be the cause? |
|
Let me check |
|
Hm it works nicely on my local machine ... I just triggered another build for sqlite |
|
Works :) |
| }, function () { done(); }); | ||
| }); | ||
|
|
||
| it("shouldn't enforce if we provide autoMigrateOldSchema option", function (done) { |
There was a problem hiding this comment.
Could you please add a check before and after the migration, that ensures the previously old table structure is now the new one?
|
Besides the little note about the test everything looks good :) Thanks a lot! |
- Check if SequelizeMeta has changed fields
Locally it worked flawless also, but since it has failed on Travis, I've supposed that it was intermittent.
Nice to ear that! I've already added checks for SequelizeMeta table schema. Ready to merge. |
|
nice! |
Auto migrate from old schema by checking autoMigrateOldSchema option
|
just released 1.0.5 |
|
That was fast as hell!!! |
|
Thank you! btw. I added some words about that topic to the readme file |
|
Changes Unknown when pulling 5afbf55 on cusspvz:patch/allow_old_migration_by_forcing into * on sequelize:master*. |
|
Changes Unknown when pulling 5afbf55 on cusspvz:patch/allow_old_migration_by_forcing into * on sequelize:master*. |
fix demoDirectory on windows
closes #82