Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't db:migrate detect old_schema and convert table automatically? #82

Closed
cusspvz opened this issue Jan 19, 2015 · 7 comments · Fixed by #84
Closed

Shouldn't db:migrate detect old_schema and convert table automatically? #82

cusspvz opened this issue Jan 19, 2015 · 7 comments · Fixed by #84

Comments

@cusspvz
Copy link

cusspvz commented Jan 19, 2015

Since we and many more of us have auto-deploy on green, sequelize db:migrate:old_schema command doesn't seems to be a nice approach. Specially for those (our case) who have servers running and protected against manual access.

Shouldn't db:migrate task check if it needs to migrate from old_schema and migrate automatically?

ping @sdepold @mickhansen

@sdepold
Copy link
Member

sdepold commented Jan 19, 2015

That would probably make sense. Are you in the mood to provide a PR ?

@cusspvz
Copy link
Author

cusspvz commented Jan 19, 2015

Yup, of course!

How would you prefer?

I have 3 proposals:

  • Check for an argument like --old-schema-migrate, or
  • Auto migrate schema on non 'development' envs, or
  • Auto migrate schema and warning user.

@sdepold
Copy link
Member

sdepold commented Jan 19, 2015

Do you have an opinion about a special entry in the config file? autoMigrateSchema which you can set to true ?

@cusspvz
Copy link
Author

cusspvz commented Jan 19, 2015

Nice! That makes more sense!

What name do you prefer: autoMigrateSchema or autoMigrateOldSchema?

@sdepold
Copy link
Member

sdepold commented Jan 19, 2015

Probably the latter one as it states old

@cusspvz
Copy link
Author

cusspvz commented Jan 19, 2015

I prefer the last one also. Doing it.

@sdepold
Copy link
Member

sdepold commented Jan 19, 2015

Great thanks!

codetriage-readme-bot pushed a commit to codetriage-readme-bot/cli that referenced this issue Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants