Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Special characters in password are not escaped #722

Merged
merged 1 commit into from
May 5, 2019

Conversation

FelixLC
Copy link
Contributor

@FelixLC FelixLC commented Dec 4, 2018

#172 is still happening when special characters find their way in a password

sequelize#172 is stil open when special characters find their way in a password
@FelixLC
Copy link
Contributor Author

FelixLC commented Dec 4, 2018

The test suite is quite scattered around multiple files; I tried to test using docker-compose and init config but I feel it would be better to test filteredUrl in a unit test what do you think ?

@sushantdhiman
Copy link
Contributor

@FelixLC unit test works

@staadecker
Copy link

Any updates? Also see #774

@agonza1
Copy link

agonza1 commented May 5, 2019

This seems to work. I just tried changing the MySQL password to "12p@ss*word34" and the password was filtered correctly to ***
And there is already a unit test in place: filters the password in test/url.test.js

@SimonSchick SimonSchick merged commit cd57b40 into sequelize:master May 5, 2019
codetriage-readme-bot pushed a commit to codetriage-readme-bot/cli that referenced this pull request Jun 5, 2019
 Handle exercise directories with numeric suffixes
@tsonev7
Copy link

tsonev7 commented Jun 6, 2019

Any idea when this will be pushed to npm ?

@SimonSchick
Copy link

@sushantdhiman

@jeremyhon
Copy link

jeremyhon commented Jun 13, 2019

This seems to have been landed in v5.5.0. Thanks @sushantdhiman

@pekzanan
Copy link

Hello, It seem that there is still a problem when password have : inside
For example, "12p:@ss*word34" it would return 'password authentication failed for user'. I tried to encode the password via URIencode, but not help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants