Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging sensitive info when using connection url. #172

Closed
einnjo opened this issue Aug 25, 2015 · 3 comments
Closed

Logging sensitive info when using connection url. #172

einnjo opened this issue Aug 25, 2015 · 3 comments

Comments

@einnjo
Copy link

einnjo commented Aug 25, 2015

I'm using the database connection url as an alternative to the config file. Whenever I run a migration, gulp outputs some logs that expose the url. Is there a way to avoid this without the config file?

Example logs:

> com.***@1.0.0 migrate /Users/juanjo/development/web/backend
> sequelize --url postgres://$DB_USERNAME:$DB_PASSWORD@$DB_HOST/$DB_NAME db:migrate


Sequelize [Node: 0.12.0, CLI: 1.7.4, ORM: 3.6.0, pg: ^4.2.0]

Parsed url postgres://user:password@localhost/database *** <--- Hide this?
Using gulpfile ~/development/web/backend/node_modules/sequelize-cli/lib/gulpfile.js
Starting 'db:migrate'...
Finished 'db:migrate' after 75 ms
No migrations were executed, database schema was already up to date.
@sdepold
Copy link
Member

sdepold commented Aug 27, 2015

It'S currently not build in but should be an easy thing to remove. Would you like to provide a PR?

@sdepold
Copy link
Member

sdepold commented Aug 27, 2015

@juanjoLenero is that change good enough? #164

@einnjo
Copy link
Author

einnjo commented Aug 27, 2015

Yes, that'll work, thank you.

@einnjo einnjo closed this as completed Aug 27, 2015
FelixLC added a commit to FelixLC/cli that referenced this issue Dec 4, 2018
sequelize#172 is stil open when special characters find their way in a password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants