Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix spelling of substitutions in lib/helpers/mail/mail.js #250

Closed
wants to merge 2 commits into from
Closed

Conversation

cwilby
Copy link

@cwilby cwilby commented Jun 27, 2016

No description provided.

@cwilby cwilby changed the title Fix spelling of substitutions in lib/helpers/mail/mail.js [WIP] Fix spelling of substitutions in lib/helpers/mail/mail.js Jun 27, 2016
@thinkingserious
Copy link
Contributor

Awesome, thanks @cameronoca!

To merge this I will need a signed CLA: https://github.com/sendgrid/sendgrid-nodejs/blob/master/CONTRIBUTING.md#cla

Thanks!

@julio-vaz
Copy link

Are you seriously ignoring a bug in your master branch(release) because of bureaucracy? This bug is affecting us and we're using a workaround that writes the content of substition inside of substitution in the object.

@thinkingserious
Copy link
Contributor

Thanks for the vote @julio-vaz. Every vote or comment helps move tasks up our priority queue.

When this one bubbles up to the top, if the CLA is still not signed, we will make the changes ourselves.

There are a few things that can continue to help this gain priority:

  1. More +1's or comments
  2. The CLA to this change to be signed
  3. A new pull request with a signed CLA

Apologies for the delay and we will get this fixed as soon as we can.

@julio-vaz
Copy link

It's been 23 days already! What more do you guys need?

@thinkingserious
Copy link
Contributor

Hi @julio-vaz,

I appreciate your frustration, we want this to be fixed 23 days ago.

Unfortunately, we have quite a few tickets above this one that need to be fixed, all important. We are doing our best to solve them as fast as we can.

That said, I appreciate your voice as it will help us make the case to increase our resources to solve these issues faster.

We are agile and we constantly are iterating towards improvement. We thank you once again for taking the time to express your feedback.

@thinkingserious
Copy link
Contributor

I'm going to go ahead and fix this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants