Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Getting Substitutions in "BCC or CC" #245

Closed
harshitanand opened this issue Jun 17, 2016 · 8 comments
Closed

Not Getting Substitutions in "BCC or CC" #245

harshitanand opened this issue Jun 17, 2016 · 8 comments
Labels
status: duplicate duplicate issue

Comments

@harshitanand
Copy link

Issue Summary

if have been using transaction templates of sendgrid to send mails. We too have substitutions in mail templates. I am setting {CC and BCC} in every mail but not getting substitutions there in CC'ed mails.

Steps to Reproduce

  1. send mail to someone using sendgrid templates and add cc mail.
  2. Don't forget to add substitutions.
  3. You won't be able to see subtitution in cc'ed mails.

Technical details:

  • sendgrid-nodejs Version: 2.0.0
  • Node.js Version: 4.1.2
@thinkingserious thinkingserious added the status: duplicate duplicate issue label Jun 17, 2016
@thinkingserious
Copy link
Contributor

Hello @harshitanand,

Thanks for the issue report. We are tracking this problem here: #243

Thanks!

@angus-ics
Copy link

Lines 617 - 630 in helpers/mail/mail.js

this.addSubstitution = function(substition) {
    if(this.substitions == undefined){
      this.substitions = {}
    }
    this.substitions[Object.keys(substition)[0]] = substition[Object.keys(substition)[0]]
  }

  this.getSubstitutions = function() {
    return this.substitions
  }

Did you mean to use substitutions instead of 'substitions'.

@thinkingserious
Copy link
Contributor

@angus-ics yes, there is a pull request to fix this: #250

I'm hoping to get that merged soon. If we don't get the CLA shortly, we will go ahead and make the fix.

Thanks for following up!

@julio-vaz
Copy link

Please do the merge. This bug is affecting the whole community.

@swarm1
Copy link

swarm1 commented Aug 17, 2016

It seems the problem is still not solved in v.2.0.0

@thinkingserious
Copy link
Contributor

@swarm1,

Could you please give us some example code? I'm happy to investigate. Thanks!

@Jatinthakkar
Copy link

I am using java API V2, how do i fix this ?

@thinkingserious
Copy link
Contributor

Hi @Jatinthakkar,

Thanks for reaching out to us!

Could you please post your question here along with some sample code so that I may try and reproduce the error?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate duplicate issue
Projects
None yet
Development

No branches or pull requests

6 participants