-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the miniled setting on reboot. #2803
Conversation
Appears to workaround firmware bug as described in seerge#2802
Thanks for the nice logs, it made authoring a proposed patch to fix this very easy :) |
@BillyONeal hello, thanks for PR. I see that you propose to force setting miniled status on every app start. I'm just not sure if all miniled devices reset their miniled status on reboot (cause otherwise it will be a lot of complains already) I can suggest to make this optional - i.e. force miniled command if some config parameter is set? |
Sure! I just didn't want to file an issue without at least making an attempt to fix it, feel free to do/suggest anything else. Forgive me, I've only really looked at this one .cs file, do you want to just read a different AppConfig value (as in, someone has to dig around in appdata to set it?) or do you want a checkbox on the 'Extra' page somehow? Thanks for your consideration! |
Today I discovered an edge case this does not fix: If the machine boots with an external display connected, and the built in one is turned on later, it's still broken. |
… external to internal or vice versa.
Removed in favor of 1c1cdf1 |
Fixes #2802
Appears to workaround firmware bug as described in #2802