Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the miniled setting on reboot. #2803

Closed
wants to merge 4 commits into from

Conversation

BillyONeal
Copy link

@BillyONeal BillyONeal commented Jul 3, 2024

Fixes #2802

Appears to workaround firmware bug as described in #2802

Appears to workaround firmware bug as described in seerge#2802
@BillyONeal BillyONeal marked this pull request as ready for review July 3, 2024 05:26
@BillyONeal
Copy link
Author

Thanks for the nice logs, it made authoring a proposed patch to fix this very easy :)

@seerge
Copy link
Owner

seerge commented Jul 3, 2024

@BillyONeal hello, thanks for PR. I see that you propose to force setting miniled status on every app start.

I'm just not sure if all miniled devices reset their miniled status on reboot (cause otherwise it will be a lot of complains already)

I can suggest to make this optional - i.e. force miniled command if some config parameter is set?

@BillyONeal
Copy link
Author

I can suggest to make this optional - i.e. force miniled command if some config parameter is set?

Sure! I just didn't want to file an issue without at least making an attempt to fix it, feel free to do/suggest anything else.

Forgive me, I've only really looked at this one .cs file, do you want to just read a different AppConfig value (as in, someone has to dig around in appdata to set it?) or do you want a checkbox on the 'Extra' page somehow?

Thanks for your consideration!

@BillyONeal BillyONeal marked this pull request as draft July 3, 2024 19:06
@BillyONeal
Copy link
Author

Today I discovered an edge case this does not fix: If the machine boots with an external display connected, and the built in one is turned on later, it's still broken.

@BillyONeal BillyONeal marked this pull request as ready for review July 4, 2024 04:54
@BillyONeal
Copy link
Author

BillyONeal commented Jul 4, 2024

OK, I made the behavior conditionally dependent on a new checkbox. Please feel free to bikeshed the name, or if this is not what you meant just chop off the last 2 commits.

image

@BillyONeal
Copy link
Author

Removed in favor of 1c1cdf1

@BillyONeal BillyONeal closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mini-led setting doesn't appear to be re-applied after reboot
2 participants