Mini-led setting doesn't appear to be re-applied after reboot #2802
Comments
|
Looks like a firmware bug to me :( OK based on g-helper/app/Display/ScreenControl.cs Line 158 in 16bdb5d Hmmm interesting that that happened again... OK this is the first mode change to 'Multi Zone': And the second to 'Multi Zone Strong': And the third back to 'Single Zone'. Which is back to 2 which is what we started at, but the display is actually behaving correctly now. Perhaps I should try Armory Crate and see if it has the same funny behavior |
Appears to workaround firmware bug as described in seerge#2802
|
@BillyONeal hello, I'm replying here (instead of PR comments), cause I want to figure out reasons first So on Scar 18 - system doesn't remember last used Multi/single zone toggle, and always forces Multizone, right ? Cause form log i see that app reads status on start and it's actually 2 (i.e. single-zone). So it shows that in the UI. And on G14 2023 - everything is working correctly in all cases ? Can you check how it behaves with AC, i.e. if it also resets on reboot? Or does AC somehow force last used mode on start (then you would probably notice a switch at some moment during windows boot |
Correct, the UI shows single zone but the actual backlight behavior is multi zone.
I believe so.
I'm not sure I understand the question: that the setting is reset on reboot is the bug.
I don't see any change in behavior during Windows boot. I wouldn't be surprised if the UEFI is changing this to show the boot logo but not updating some firmware bits. Let me try turning the logo off and see if that changes anything.... |
Well, I was wondering if you would install Armoury - would it "force" last used single/multizone setting when it or it's services start ? (Pretty much what you suggest to do in G-Helper) |
I'll give this a shot, I pretty much never used Armory Crate so I don't know what it does. (G-Helper is why I bought this machine and the first thing I did out the box was throw out Armory Create and install G-Helper instead) |
|
I can confirm Armory Crate appears to suffer the same problem; the system is clearly not in single backlight mode on boot, then eventually Armory Crate wakes up and switches it to single backlight mode. |
|
Armory Crate also suffers from the bug I wrote in #2803 where when the system doesn't boot to the internal monitor it doesn't reset the setting |
|
@BillyONeal just out of curiosity, can you try CMOS / Hardware reset? I just wonder if it's an individual hiccup of your specific device or is it behavior of the BIOS on all G843JYR ? |
seerge
changed the title
CMOS / Hardware reset caused G-Helper to display 'Multi Zone' on the next reboot but didn't otherwise fix the problem. Selecting 'One Zone' and rebooting still reboots with the physical display clearly in 'Multi Zone' but G-Helper's UI says 'Single Zone'. You can see when the display mode switches to multizone while showing the boot logo. I tried to take video to show you but sadly the backlight difference didn't show up all that well in the video :( |
Unfortunately I don't have another one to test 😅 |
|
@BillyONeal Ok, great. I guess it's safe to assume that it's specific behavior of your model (not your device only) I don't think it makes sense to overload UI with extra checkboxes that 99% of users don't need. I usually just do such things this via optional config params. Also forcing Please try this build. It should force miniled command only for your model (G843JYR) or if |
That's fair
This one I don't think is specific to my model, I'll have to try with the other one when I get access to it again, but admittedly it's a different bug than this one. I just noticed it because I was paying attention while trying to author #2803 . It's fair to close this and I'll open a different one if I still experience the problem. (That is, I think if the built-in display is off because an external display is in use when G-Helper tries to apply refresh rate, overdrive, or other screen changes, that doesn't stick) Trying the build you supplied now (I have to post before trying because testing that it's fixed requires a reboot) |
If other modes are affected, we can always extend the list :) Line 660 in 1c1cdf1 And btw, sorry for offering own solution, I didn't mean to offend you anyhow. I'm just trying not to set any settings / send any commands in the app unless user explicitly chooses so. Except it's some unique cases, like fixing firmware behavior. |
This did not fix it, I think just the model detection didn't work. I tried manually adding that to config.json but apparently did a syntax error.... cursed trailing commas. Trying again after I post this comment...
No offense taken! I certainly respond with different solutions to contributors so I get it. Like I said, the only reason I tried at all is that I didn't want to just complain about a problem without attempting to fix it, particularly since I have the device in hand and can test in-situ and you don't.
That makes sense! |
|
OK when Bill is not a dum dum editing config.json, adding |
|
I think it needs: diff --git a/app/AppConfig.cs b/app/AppConfig.cs
index d0da418..b3419b7 100644
--- a/app/AppConfig.cs
+++ b/app/AppConfig.cs
@@ -659,7 +659,7 @@ public static class AppConfig
public static bool IsForceMiniled()
{
- return ContainsModel("G843JYR") || Is("force_miniled");
+ return ContainsModel("G834JYR") || Is("force_miniled");
}
} |
|
I realize that I made this typo in the initial report, sorry! |
|
@BillyONeal I just copied model name from what you have typed, apparently it's G834JYR :) I assume it's resolved now. |
|
Thanks 👍 |
|
I confirm the other problem (things not sticking when internal display is off) remains, I'll see if it repros on the other machine and file a new bug with more complete information. Thanks again! |
|
@BillyONeal do you mean that it remains on G834JYR or on other model ? |
|
It remains on the G834JYR; I want to check if it does the same thing on my 2023 G14 so that I understand what's going on better before bothering you again, but I don't have that machine with me at the moment. (This was why I made it listen to
|
|
@BillyONeal ah, i see. But setting refresh rate every time display config changes is also not an option. I literally had a guy here, who's display was starting flicker if you would set same refresh rate as it had before ... |
|
And I just checked the similar repro with the miniled setting: If the internal display is off when G-Helper turns on I still experience the out of sync miniled bug. (G-Helper is now matching Armory Crate's behavior.) That is, on the G834JYR:
If you do the same thing with Armory Crate the same bug happens 😭. But this edge case is much less frequent than every reboot so I don't care much
Sure, please don't take my 'I spent 10 minutes on this and it kinda works' guess attempt as 'this is the exact change I think should be' :) Given that G-Helper is enabling and disabling the buttons in the UI at the right time without listening to
😭 |
|
@BillyONeal oh, ok. Can you check app log for what happens on that moment ? And after that run init miniled command (for your model) g-helper/app/Helpers/ClamshellModeControl.cs Line 111 in 35c7f42 |
Rules
What's wrong?
When my machine boots, it appears to have 'forgotten' to disable the multi-zone backlight. If I cycle the backlight setting 3 times, everything seems to work perfectly afterwards.
How to reproduce the bug?
Logs
log.txt
config.json
Device and Model
Strix SCAR 18 G843JYR
Additional information.
I also tried this on a 2023 Zepherus G14 which only has multi zone on or off and G-Helper seems to work perfectly there, so I'm not sure if this is a firmware problem or G-Helper not behaving the same way given that this model has multiple multi zone backlight modes.
Armoury Crate
Uninstalled
Asus Services
0
Version
0.176.0
OS
Windows 11 Version 23H2 (OS Build 22631.3737)
The text was updated successfully, but these errors were encountered: