Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skuba start fastify support #1101

Merged
merged 9 commits into from
Feb 6, 2023
Merged

Add skuba start fastify support #1101

merged 9 commits into from
Feb 6, 2023

Conversation

samchungy
Copy link
Contributor

@samchungy samchungy commented Feb 5, 2023

Tested on my upcoming template:

samchungy/test-fastify-template#1

@samchungy samchungy requested review from a team as code owners February 5, 2023 04:15
@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2023

🦋 Changeset detected

Latest commit: 95026b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

src/wrapper/requestListener.ts Show resolved Hide resolved
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

Up to you on whether you want to changeset this PR or leave it until you have more to share 🙂

@samchungy samchungy merged commit b62e585 into master Feb 6, 2023
@samchungy samchungy deleted the hack-fastify-support branch February 6, 2023 06:29
@seek-oss-ci seek-oss-ci mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants