Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #1079

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Version Packages #1079

merged 1 commit into from
Mar 20, 2023

Conversation

seek-oss-ci
Copy link
Contributor

@seek-oss-ci seek-oss-ci commented Dec 30, 2022

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

skuba@6.0.0

Major Changes

  • deps: Require Node.js 16.11+ (#1124)

    Node.js 14 will reach end of life by April 2023.

    Consider upgrading the Node.js version for your project across:

    • .nvmrc
    • package.json#/engines/node
    • CI/CD configuration (.buildkite/pipeline.yml, Dockerfile, etc.)

Minor Changes

  • format, lint: Prepend baseline SEEK renovate-config preset (#1117)

    skuba format and skuba lint will now automatically prepend an appropriate baseline preset if your project is configured with a SEEK-Jobs or seekasia remote:

    // SEEK-Jobs
    {
    - extends: ['seek'],
    + extends: ['local>seek-jobs/renovate-config', 'seek'],
    }
    
    // seekasia
    {
    - extends: ['seek'],
    + extends: ['local>seekasia/renovate-config', 'seek'],
    }

    Renovate requires this new configuration to reliably access private SEEK packages. Adding the preset should fix recent issues where Renovate would open then autoclose pull requests, and report ⚠ Dependency Lookup Warnings ⚠.

    See SEEK-Jobs/renovate-config and seekasia/renovate-config for more information.

  • format, lint, template/*-rest-api: Set keepAliveTimeout to 31 seconds to prevent HTTP 502s (#1111)

    The default Node.js server keep-alive timeout is set to 5 seconds. However, the Gantry default ALB idle timeout is 30 seconds. This would lead to the occasional issues where the sidecar would throw proxyStatus=502 errors. AWS recommends setting an application timeout larger than the ALB idle timeout.

    skuba format and skuba lint will now automatically append a keep-alive timeout to a typical src/listen.ts:

    // With a listener callback
    const listener = app.listen(config.port, () => {
      const address = listener.address();
    })
    +
    + listener.keepAliveTimeout = 31000;
    
    // Without a listener callback
    - app.listen(config.port);
    + const listener = app.listen(config.port);
    +
    + listener.keepAliveTimeout = 31000;

    A more detailed explanation can be found in the below links:

    1. https://docs.aws.amazon.com/elasticloadbalancing/latest/application/application-load-balancers.html#connection-idle-timeout
    2. https://nodejs.org/docs/latest-v18.x/api/http.html#serverkeepalivetimeout
  • format, lint: Bundle eslint-plugin-yml (#1107)

    eslint-plugin-yml is now supported on skuba format and skuba lint. While the default configuration should be unobtrusive, you can opt in to stricter rules in your .eslintrc.js:

    module.exports = {
      extends: ['skuba'],
    + overrides: [
    +   {
    +     files: ['my/strict/config.yaml'],
    +     rules: {
    +       'yml/sort-keys': 'error',
    +     },
    +   },
    + ],
    };

    YAML files with non-standard syntax may fail ESLint parsing with this change. Gantry resource files should be excluded by default due to their custom templating syntax, and you can list additional exclusions in your .eslintignore.

  • start: Add Fastify support (#1101)

    skuba start can now be used to create a live-reloading server for Fastify based projects. See the skuba start documentation for more information.

  • format, lint: Configure ESLint for {cjs,cts,mjs,mts} files (#1126)

  • lint: Commit codegen updates (#1078)

    skuba lint can locally codegen updates to ignore files, module exports and Renovate configuration. These changes are now automatically committed if you have GitHub autofixes enabled on your project.

  • deps: TypeScript 5.0 (#1118)

    This major release includes breaking changes. See the TypeScript 5.0 announcement for more information.

Patch Changes

  • init: Include baseline SEEK renovate-config preset (#1117)

  • template/*-package: Require Node.js 16.11+ (#1124)

  • lint: Delete Dockerfile-incunabulum (#1078)

    skuba lint may have accidentally committed this internal file to source control in prior versions. It is now automatically removed if you have GitHub autofixes enabled on your project.

@seek-oss-ci seek-oss-ci requested review from a team as code owners December 30, 2022 01:12
@72636c 72636c marked this pull request as draft December 30, 2022 01:23
@72636c 72636c added the dino:snooze Snooze in Review Dino label Dec 30, 2022
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 3 times, most recently from 8f8b0c4 to 154e1cb Compare January 3, 2023 18:42
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 7 times, most recently from 24f6bb9 to b3108fb Compare January 22, 2023 22:27
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 6 times, most recently from d34e4f2 to 4e67889 Compare February 3, 2023 05:43
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 4 times, most recently from 676437b to 6825f90 Compare February 9, 2023 22:07
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 2 times, most recently from f2f6f6e to deb4c5c Compare February 16, 2023 04:22
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 3 times, most recently from 0773561 to 9ca4718 Compare February 27, 2023 21:07
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 7 times, most recently from e66e280 to d261c1d Compare March 18, 2023 05:04
@72636c
Copy link
Member

72636c commented Mar 18, 2023

Would be ideal to wait for prettier/prettier#14240 and seek-oss/eslint-config-skuba#177

@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 7 times, most recently from 863eb1b to 300e842 Compare March 19, 2023 10:32
@72636c 72636c removed the dino:snooze Snooze in Review Dino label Mar 20, 2023
@72636c 72636c marked this pull request as ready for review March 20, 2023 10:08
@72636c 72636c enabled auto-merge (squash) March 20, 2023 10:08
@72636c 72636c merged commit 08b0c03 into master Mar 20, 2023
@72636c 72636c deleted the changeset-release/master branch March 20, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants