Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #1232

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Version Packages #1232

merged 2 commits into from
Feb 24, 2023

Conversation

seek-oss-ci
Copy link
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

braid-design-system@32.0.0

Major Changes

  • Drop support for React 16. (#1229)

    To support the pre-compilation of Braid, it is now a requirement that consumers are on React 17 or later.
    Originally the plan was to drop React 17 as well, however the team has been able to maintain support for a little longer — but there is a catch (see migration guide below).

    MIGRATION GUIDE:

    React 16 consumers

    As this version is no longer supported it is a requirement that consumers upgrade.
    For more information on the differences between v16 and v17, see the React blog.
    We strongly encourage teams to take this opportunity to upgrade to v18 as well.

    React 17 consumers

    The way React 17 exposes the jsx-runtime is not compatible with ESM, which means the bundler will need instructions on how to resolve the import.
    This can be done by adding a fallback module resolve rule to the webpack configuration.

    For sku consumers, this can be done as follows:

    // sku.config.ts
    {
      dangerouslySetWebpackConfig: (config) =>
        webpackMerge(config, {
          resolve: {
            fallback: {
              'react/jsx-runtime': require.resolve('react/jsx-runtime'),
            },
          },
        }),
    }

    We recommend using webpack-merge to ensure both configurations are deep merged correctly.

    Note: This rule can be removed after upgrading to React 18, which has ESM support.

    React 18 consumers

    No action required.

  • Playroom imports are now formalised entrypoints rather than path imports, and as such no longer require the file path extensions to be provided. (#1229)

    EXAMPLE USAGE:

    // playroom.config.js
    module.exports = {
      frameComponent: require.resolve(
        'braid-design-system/playroom/FrameComponent',
      ),
      components: require.resolve('braid-design-system/playroom/components'),
      snippets: require.resolve('braid-design-system/playroom/snippets'),
      scope: require.resolve('braid-design-system/playroom/scope'),
    };
  • Remove legacy themes: catho, occ and seekAnz (#1229)

    The seekAnz theme facilitated consumers migrating like-for-like from seek-style-guide, while the catho and occ themes intended to enable a specific use case that never eventuated.

    Removing these themes allows us to move faster with upcoming theme uplift work.

    MIGRATION GUIDE:

    Any remaining consumers of the catho, occ or seekAnz themes should migrate to the apac theme like so:

    -import seekAnz from 'braid-design-system/themes/seekAnz';
    +import apac from 'braid-design-system/themes/apac';
  • Remove treat support (#1229)

    Treat has been deprecated for nearly 2 years, superseded by vanilla-extract.
    .treat.ts files can no longer be used for styling and should be converted to .css.ts (vanilla-extract) stylesheets.

  • Remove experimental color-mode check script (#1229)

    The experimental script for checking which color mode to render has been formalised to an entrypoint specific to the mechanism that is being used — in this case the query parameter.
    In the future we may add other mechanisms, such as local storage for example, but for now all existing consumers should have been migrated to the query-param check.

    MIGRATION GUIDE:

    - import { __experimentalDarkMode__ } from 'braid-design-system/color-mode'
    + import { colorModeQueryParamCheck } from 'braid-design-system/color-mode/query-param'

@seek-oss-ci seek-oss-ci requested a review from a team as a code owner February 24, 2023 04:10
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
@mrm007
Copy link
Collaborator

mrm007 commented Feb 24, 2023

👍

image

@michaeltaranto michaeltaranto merged commit a477b3a into master Feb 24, 2023
@michaeltaranto michaeltaranto deleted the changeset-release/master branch February 24, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants