Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Rewrite in TypeScript #4
♻️ Rewrite in TypeScript #4
Changes from 3 commits
7d71712
0d883f6
850c949
83003e4
6a5156c
6cfdf69
6496225
97b2acb
6a9287d
c6a1d7f
de0d653
1596de2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that this and a few of the ones in devDeps don't have a
^
in front of the version; any particular reason? Would be nice to have them all defined the same way if not. (I noticed because the yarn lock update in ss-embed was listing both^4.2.4
and4.2.4
fores6-promise
separately).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For devDependencies, it mostly came down to the ones I don't trust to follow semver. TypeScript introduces breaking changes outside of major version releases, so I didn't allow it (or tslint+friends) to auto-upgrade.
For dependencies, it's because this is a public library and I wanted to pin very specific dependency versions as "actually tested to work".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After talking further offsite, let's go with
~
-- it should be safe enough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it's always helpful to have the units as part of the variable name:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to avoid bumping the major version number and this would be changing the public API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not that familiar with talker; can you explain why we'd ever want to keep going here if the message data failed JSON parsing? (And preferably add a comment to the code.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a feature of the library that data-less messages can be sent via Talker. This handles that scenario (e.g.
JSON.parse(undefined)
,JSON.parse('')
, etc.).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in the future it should be a falsey check to fallback to this + actually error on malformed JSON? Probably not something to change now though.