♻️ Rewrite in TypeScript #4
Conversation
Co-Authored-By: Kerrick <me@kerricklong.com>
| @@ -0,0 +1,53 @@ | |||
| { | |||
There was a problem hiding this comment.
Maybe update this to match https://github.com/secondstreet/template-builder/blob/master/tslint.json? (If you add the prettier rule and plugin, update the lint-staged config to match as well.)
There was a problem hiding this comment.
I agree it would be a good idea to unify but given that we have multiple tslint configs across multiple projects, I'd like to keep this PR concerned with what it currently is, and handle tslint config unification across everywhere as its own project.
|
|
||
| module.exports = [ | ||
| { | ||
| ...commonConfig, |
There was a problem hiding this comment.
This works here because the two objects have distinct sets of keys, but consider switching to https://github.com/survivejs/webpack-merge for a more robust webpack config merging solution.
There was a problem hiding this comment.
Will definitely keep that in mind in case the keys ever become non-distinct.
package.json
Outdated
| "webpack-cli": "^3.1.2" | ||
| }, | ||
| "dependencies": { | ||
| "es6-promise": "4.2.4" |
There was a problem hiding this comment.
Just noticed that this and a few of the ones in devDeps don't have a ^ in front of the version; any particular reason? Would be nice to have them all defined the same way if not. (I noticed because the yarn lock update in ss-embed was listing both ^4.2.4 and 4.2.4 for es6-promise separately).
There was a problem hiding this comment.
For devDependencies, it mostly came down to the ones I don't trust to follow semver. TypeScript introduces breaking changes outside of major version releases, so I didn't allow it (or tslint+friends) to auto-upgrade.
For dependencies, it's because this is a public library and I wanted to pin very specific dependency versions as "actually tested to work".
There was a problem hiding this comment.
After talking further offsite, let's go with ~ -- it should be safe enough.
No description provided.