feat(accessibility): Move aria-live=polite to overlay container
#934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also updates the README.md to let authors know they'll need this attribute if they're doing custom overlay containers
dialogs/alertdialogs are intended to receive focus when they're shown. toasts, by their very nature, are not meant to steal focus but happen in parallel/as an aside
Codecov Report
@@ Coverage Diff @@
## master #934 +/- ##
==========================================
+ Coverage 55.29% 55.96% +0.67%
==========================================
Files 19 19
Lines 510 511 +1
Branches 88 88
==========================================
+ Hits 282 286 +4
Misses 216 216
+ Partials 12 9 -3
Continue to review full report at Codecov.
|
|
Video recording of https://ngx-toastr-dp73gf4hr-scoop1.vercel.app/ (using Chrome/NVDA) showing that after this change, all toasts are announced correctly and consistently (compare to the video in #933) ngx-toastr-live-region-issue-fixed.mp4 |
scttcper
changed the title
aria-live="polite" to the overlay container, change role="alertdialog" to role="alert"aria-live="polite" to the overlay container, change role="alertdialog" to role="alert"
scttcper
changed the title
aria-live="polite" to the overlay container, change role="alertdialog" to role="alert"aria-live=polite to overlay container
|
🎉 This PR is included in version 14.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks @scttcper :) |
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #933, closes #444, closes #833
(note that I'm not too hot on angular per se, so this may need tweaking/correcting. In particular the change made to the README.md)