-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility Enhancement #833
Comments
These are my findings as well. I mentioned having problems with JAWS in #444 - I believe this difference in roles is the reason. For example, on the demo page, the pink alert example will be read out by JAWS, but other toasts aren't being read. The pink alerts are using role="alert". |
As a workaround for our project, I have just gone with the custom component implementation, extended the toast class and made the necessary changes in the template as necessary. I also feel like we shouldn't be using |
🎉 This issue has been resolved in version 14.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hello everyone! The issue is still reproducible on the demo page. thank you |
We would like to create a pull request to add a little more nuance to the good work you've already done. Currently the component is using role="alertdialog" and our reading of the guidance indicates that role="alert" would be more appropriate for most implementations.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_alertdialog_role
Perhaps there should be an option for this modal 'alertdialog' to include a dimmer, and a center/center position.
https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/alertdialog.html
We don't know whether the 'alertdialog' special case should be driven by the enableHtml property, or an additional modal boolean.
Would appreciate your thoughts. We've just added ngx-toastr to our design system dependencies and appreciate all the great functionality on top of the CDK. We'd be happy to take a crack at this enhancement and add it to our roadmap.
::Michael
The text was updated successfully, but these errors were encountered: