Randomized id for svg filters #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also resolves #889, probably. |
|
LGTM, Paul should double-check in context of scratch-gui. |
|
You're right, it would resolve #889. I updated the description. |
|
Wonderful! Thanks! |
paulkaplan
approved these changes
May 31, 2018
|
As a follow up, it looks like we missed passing the stack glow filter id down into the toolbox/flyout workspace, which caused blocks in the toolbox to disappear when clicked! Fixed now, my bad for missing that fact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #1549
Resolves #889
Proposed Changes
Randomly generate the id for the stack glow filter and replacement glow filter
Reason for Changes
When
injectis called for an embedded workspace (ie. when displaying the custom procedures modal), the stack and replacement glow filters are generated again with the same ID as the original instances. This is an issue in Safari and iOS browsers which then stop displaying the filters when the embedded workspace is destroyed. By randomly generating the filter IDs, we prevent collisions.Test Coverage
Tested by instantiating an embedded workspace and verifying the fix.