Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocklyStackGlowFilter does not have a unique id #889

Closed
rachel-fenichel opened this issue May 12, 2017 · 0 comments · Fixed by #1551
Closed

blocklyStackGlowFilter does not have a unique id #889

rachel-fenichel opened this issue May 12, 2017 · 0 comments · Fixed by #1551
Milestone

Comments

@rachel-fenichel
Copy link
Collaborator

https://github.com/LLK/scratch-blocks/blob/develop/core/inject.js#L118 states that

// Each filter/pattern needs a unique ID for the case of multiple Blockly
// instances on a page. Browser behaviour becomes undefined otherwise.
// https://neil.fraser.name/news/2015/11/01/
// TODO (tmickel): Look into whether block highlighting still works.

but the stack glow filter and replacement glow filter do not follow this rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants