Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare w3lib as providing type hints #184

Merged
merged 1 commit into from
Aug 9, 2022
Merged

declare w3lib as providing type hints #184

merged 1 commit into from
Aug 9, 2022

Conversation

kmike
Copy link
Member

@kmike kmike commented Aug 8, 2022

Type annotations for w3lib were added in #172; however, for mypy to use the when code which depends on w3lib is checked, w3lib should be declared as a package which provides typing information.

See https://peps.python.org/pep-0561/.

This could potentially cause typing checks for packages which depend on w3lib to start failing, either because of typing issues with this code, or because we made some mistakes in w3lib types. But I think that's the intended behavior :)

@kmike kmike requested a review from Gallaecio August 8, 2022 16:52
@kmike kmike added this to the 2.0.0 milestone Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #184 (cbc93c8) into master (81b8b34) will not change coverage.
The diff coverage is n/a.

❗ Current head cbc93c8 differs from pull request most recent head 5c45eb8. Consider uploading reports for the commit 5c45eb8 to get more accurate results

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files           7        7           
  Lines         480      480           
  Branches       93       93           
=======================================
  Hits          461      461           
  Misses          9        9           
  Partials       10       10           

@kmike kmike mentioned this pull request Aug 8, 2022
@Gallaecio Gallaecio merged commit d7d4d31 into master Aug 9, 2022
@elacuesta elacuesta deleted the py.typed branch August 9, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants