declare w3lib as providing type hints #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type annotations for w3lib were added in #172; however, for mypy to use the when code which depends on w3lib is checked, w3lib should be declared as a package which provides typing information.
See https://peps.python.org/pep-0561/.
This could potentially cause typing checks for packages which depend on w3lib to start failing, either because of typing issues with this code, or because we made some mistakes in w3lib types. But I think that's the intended behavior :)