Changelog #185
Merged
Changelog #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmike
commented
Aug 8, 2022
kmike
commented
Aug 8, 2022
|
|
||
| - `w3lib.util.str_to_unicode`` | ||
| - ``w3lib.util.unicode_to_str`` | ||
| - ``w3lib.util.to_native_str`` |
There was a problem hiding this comment.
These functions are not documented as :func:..., because they're not in w3lib.rst auto-generated API docs, and I didn't want to add them there.
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=======================================
Coverage 96.04% 96.04%
=======================================
Files 7 7
Lines 480 480
Branches 93 93
=======================================
Hits 461 461
Misses 9 9
Partials 10 10 |
Minor language and format suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should release 2.0.0, because Python 2 compat is removed, and there are some deprecation removals.