Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from pytest-flake8 to raw flake8; clean up ignores #182

Merged
merged 5 commits into from
Aug 8, 2022

Conversation

kmike
Copy link
Member

@kmike kmike commented Aug 6, 2022

pytest-flake8 doesn't work with latest flake.

It also turns out we can remove most of ignored flake8 rules.

pytest-flake8 doesn't work with latest flake
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #182 (c394ec4) into master (97ac45b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   96.02%   96.04%   +0.01%     
==========================================
  Files           7        7              
  Lines         478      480       +2     
  Branches       93       93              
==========================================
+ Hits          459      461       +2     
  Misses          9        9              
  Partials       10       10              
Impacted Files Coverage Δ
w3lib/encoding.py 98.70% <100.00%> (+0.03%) ⬆️

@kmike kmike marked this pull request as ready for review August 6, 2022 19:53
@kmike kmike requested a review from Gallaecio August 6, 2022 19:53
.flake8 Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@Gallaecio Gallaecio merged commit 6c23d82 into master Aug 8, 2022
@kmike kmike added this to the 2.0.0 milestone Aug 8, 2022
@wRAR wRAR deleted the fix-linting branch October 10, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants