-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] avoid concating #
with url if there is no fragment.
#159
Conversation
avoid adding `#` after url if there is no fragment.
Closing and reopening to trigger the CI tests again after merging #160. |
A new day, a new CI issue 😓 |
Incoming branch is 68 commits behind |
branch is updated. 👍 |
Thanks @EltonChou! |
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 7 7
Lines 478 478
Branches 93 93
=======================================
Hits 459 459
Misses 9 9
Partials 10 10
|
flake8 failure should be addressed here: #182 @EltonChou would you mind runing black on your changes, to fix the remaining CI failure? |
Actually, let me handle the failure. Thanks @EltonChou! Also, thanks @joe733 for the ping :) |
Merged as #183. |
#72 will always concate
#
with url.This PR add statement of checking fragment existence.