Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the additional request docs #197

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Refactor the additional request docs #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
677c1fe
Refactor the additional request docs
Gallaecio Jan 25, 2024
d9029dd
Do not ellaborate on HttpClient methods on the intro
Gallaecio Jan 25, 2024
e128114
Restore the separate input validation page
Gallaecio Jan 25, 2024
3a206c1
Improve the code example
Gallaecio Jan 29, 2024
6aba157
Redirection handling applies to all HttpClient methods
Gallaecio Jan 29, 2024
885d30f
Improve the remaining examples
Gallaecio Jan 29, 2024
4f27bb8
Improve the documentation around handling requests, responses, and er…
Gallaecio Jan 29, 2024
2fe49c7
Fix typing issues
Gallaecio Jan 29, 2024
79eb00a
Update docs/page-objects/additional-requests.rst
Gallaecio Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/frameworks/additional-requests.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,10 @@ syntax.
Exception Handling
------------------

In the previous :ref:`exception-handling` section, we can see how Page Object
developers could use the exception classes built inside **web-poet** to handle
various ways additional requests MAY fail. In this section, we'll see the
rationale and ways the framework MUST be able to do that.
Page Object developers could use the exception classes built inside
**web-poet** to handle various ways additional requests MAY fail. In this
section, we'll see the rationale and ways the framework MUST be able to do
that.
Comment on lines -143 to +146
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here is the removal of the first part, In the previous :ref:`exception-handling` section, we can see how, due to the removal of the referred content.


Rationale
*********
Expand Down
2 changes: 2 additions & 0 deletions docs/intro/overview.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
.. _overview:

========
Overview
========
Expand Down
Loading
Loading