Refactor the additional request docs #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
=======================================
Coverage 98.46% 98.47%
=======================================
Files 31 31
Lines 1437 1438 +1
=======================================
+ Hits 1415 1416 +1
Misses 22 22
|
Gallaecio
commented
Jan 25, 2024
Comment on lines
-143
to
+146
| In the previous :ref:`exception-handling` section, we can see how Page Object | ||
| developers could use the exception classes built inside **web-poet** to handle | ||
| various ways additional requests MAY fail. In this section, we'll see the | ||
| rationale and ways the framework MUST be able to do that. | ||
| Page Object developers could use the exception classes built inside | ||
| **web-poet** to handle various ways additional requests MAY fail. In this | ||
| section, we'll see the rationale and ways the framework MUST be able to do | ||
| that. |
There was a problem hiding this comment.
The change here is the removal of the first part, In the previous :ref:`exception-handling` section, we can see how, due to the removal of the referred content.
kmike
reviewed
Jan 25, 2024
kmike
reviewed
Jan 26, 2024
kmike
reviewed
Jan 29, 2024
kmike
reviewed
Jan 29, 2024
kmike
reviewed
Jan 29, 2024
kmike
reviewed
Jan 29, 2024
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
kmike
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the existing content felt too reference-like to me, and we already have reference documentation, but I might have gone too far with the removing of content, so please feel more than free to suggest bringing back stuff or featuring additional stuff.
I also moved the input validation page as a section of inputs, because it felt right there and it made sense to me that the content about input validation, mentioned in the additional requests page in the context of retries, was before the additional requests content in reading order.