fix error when using 'scrapy shell' #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurnzZ
force-pushed
the
fix-scrapy-shell
branch
from
f18113a to
96c1756
Compare
BurnzZ
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 10 10
Lines 451 451
=======================================
Hits 441 441
Misses 10 10
|
wRAR
approved these changes
Nov 21, 2022
|
I wonder if it's possible to add a test? |
Gallaecio
approved these changes
Nov 21, 2022
|
I removed the old conditional check for The rest of the changes are already covered by the existing tests. |
|
Thanks @BurnzZ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92
Ignore the failed tests. It's because of the new deprecated things from the recently releasedFixedweb-poet=0.6.0. The PR in #89 will address it.