Moving away from upcoming deprecated functionalities of web-poet==0.6.0 #89
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 97.88% 97.78% -0.11%
==========================================
Files 12 10 -2
Lines 473 451 -22
==========================================
- Hits 463 441 -22
Misses 10 10
|
BurnzZ
changed the title
BurnzZ
changed the title
BurnzZ
changed the title
scrapy_poet/cache.py
Outdated
| @@ -16,7 +16,8 @@ def __getitem__(self, fingerprint: str) -> Any: | |||
| def __setitem__(self, fingerprint: str, value) -> None: | |||
| pass | |||
|
|
|||
| def close(self): | |||
| @abc.abstractmethod | |||
There was a problem hiding this comment.
Why should it be an abstractmethod? Empty close seems like a good default, in case a backend doesn't need to close anything.
There was a problem hiding this comment.
Reverted it. 4a8807a
scrapy_poet/overrides.py
Outdated
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| RuleAsTuple = Union[Tuple[str, Callable, Callable], List] | ||
| RuleFromUser = Union[RuleAsTuple, OverrideRule] | ||
| PageObject = Type[ItemPage] |
There was a problem hiding this comment.
It looks a bit confusing, with x: PageObject annotation I'd expect x to be a page object instance, not a subclass of ItemPage. It seems that removing this shortcut (not even renaming it) can make the code easier to read.
tox.ini
Outdated
| @@ -38,7 +38,7 @@ deps = | |||
|
|
|||
| [testenv:mypy] | |||
| deps = | |||
| mypy==0.790 | |||
| mypy==0.982 | |||
There was a problem hiding this comment.
would it make sense to update directly to the latest mypy version (0.991)?
There was a problem hiding this comment.
Good call, as the new version picked up some typing inconsistencies. 4881d6f
|
Thanks @BurnzZ! |
Migration away from the deprecated functionalities of web-poet as introduced in scrapinghub/web-poet#84.
This PR should not receive any
DeprecationWarningfrom web-poet.TODO:
tox.iniandsetup.pywith the new web-poet version in PyPI