Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing tests after new warning phrases for dupe rules #125

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

BurnzZ
Copy link
Contributor

@BurnzZ BurnzZ commented Feb 7, 2023

Resolves #123

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #125 (0f93efa) into master (4e2d850) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 0f93efa differs from pull request most recent head 4ced013. Consider uploading reports for the commit 4ced013 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files          14       14           
  Lines         737      737           
=======================================
  Hits          655      655           
  Misses         82       82           
Impacted Files Coverage Δ
scrapy_poet/api.py 100.00% <ø> (ø)
scrapy_poet/commands.py 47.05% <0.00%> (ø)
scrapy_poet/downloadermiddlewares.py 100.00% <ø> (ø)
scrapy_poet/injection.py 98.97% <ø> (ø)
scrapy_poet/page_input_providers.py 94.91% <ø> (ø)

@kmike kmike merged commit cb79d3b into master Feb 7, 2023
@kmike
Copy link
Member

kmike commented Feb 7, 2023

Thanks @BurnzZ!

@BurnzZ BurnzZ mentioned this pull request Feb 16, 2023
2 tasks
@wRAR wRAR deleted the fix-failing-CI branch October 31, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests for the new web-poet
2 participants