Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for the new web-poet #123

Closed
wRAR opened this issue Feb 2, 2023 · 0 comments · Fixed by #125
Closed

Update tests for the new web-poet #123

wRAR opened this issue Feb 2, 2023 · 0 comments · Fixed by #125

Comments

@wRAR
Copy link
Member

wRAR commented Feb 2, 2023

web-poet changed some messages and so tests in test_web_poet_rules.py that expect a "Consider updating the priority of these rules:" message fail and tests that expect it to be absent are not checking the correct thing too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix failing tests after new warning phrases for dupe rules scrapinghub/scrapy-poet
1 participant
@wRAR