Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workaround for broken windows workflow #5693

Conversation

notimaginative
Copy link
Contributor

Temporary fix for broken windows workflow. Hopefully a more permanent solution will be found soon and we can then remove this.

Reference: actions/runner-images#8598

Temporary fix for broken windows workflow. Hopefully a more permanent
solution will be found soon and we can then remove this.

Reference: actions/runner-images#8598
@notimaginative notimaginative added ci A feature or issue related to the continous integration tools windows A windows-specific issue labels Oct 19, 2023
@notimaginative
Copy link
Contributor Author

Setting this as a draft until there is a consensus as to whether to use this temporary fix or to wait for a proper solution from github. Also this isn't directly tested but a copy&paste for the recommended workaround from linked github issue.

@JohnAFernandez
Copy link
Contributor

It would be nice to have this, so I can continue work on my github actions script.

Copy link
Contributor

@Goober5000 Goober5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it fixed the automatic builds for this PR. I say let's use it. We can revert it easily enough if we need to.

@JohnAFernandez
Copy link
Contributor

Confirmed: this does fix the issue in my script, so it should probably be merged.

@notimaginative notimaginative marked this pull request as ready for review October 19, 2023 21:38
@notimaginative notimaginative merged commit 2acdc65 into scp-fs2open:master Oct 19, 2023
14 checks passed
MjnMixael pushed a commit to MjnMixael/fs2open.github.com that referenced this pull request Oct 20, 2023
Temporary fix for broken windows workflow. Hopefully a more permanent
solution will be found soon and we can then remove this.

Reference: actions/runner-images#8598
(cherry picked from commit 2acdc65)
MjnMixael pushed a commit to MjnMixael/fs2open.github.com that referenced this pull request Oct 20, 2023
Temporary fix for broken windows workflow. Hopefully a more permanent
solution will be found soon and we can then remove this.

Reference: actions/runner-images#8598
(cherry picked from commit 2acdc65)
MjnMixael pushed a commit to MjnMixael/fs2open.github.com that referenced this pull request Oct 20, 2023
Temporary fix for broken windows workflow. Hopefully a more permanent
solution will be found soon and we can then remove this.

Reference: actions/runner-images#8598
(cherry picked from commit 2acdc65)
MjnMixael pushed a commit to MjnMixael/fs2open.github.com that referenced this pull request Oct 20, 2023
Temporary fix for broken windows workflow. Hopefully a more permanent
solution will be found soon and we can then remove this.

Reference: actions/runner-images#8598
(cherry picked from commit 2acdc65)
(cherry picked from commit 4546f59)
MjnMixael pushed a commit to MjnMixael/fs2open.github.com that referenced this pull request Oct 20, 2023
Temporary fix for broken windows workflow. Hopefully a more permanent
solution will be found soon and we can then remove this.

Reference: actions/runner-images#8598
(cherry picked from commit 2acdc65)
(cherry picked from commit 4546f59)
(cherry picked from commit d3e8dab)
MjnMixael pushed a commit to MjnMixael/fs2open.github.com that referenced this pull request Oct 20, 2023
Temporary fix for broken windows workflow. Hopefully a more permanent
solution will be found soon and we can then remove this.

Reference: actions/runner-images#8598
(cherry picked from commit 2acdc65)
(cherry picked from commit 4546f59)
(cherry picked from commit d3e8dab)
(cherry picked from commit d808140)
@notimaginative notimaginative deleted the temp_fix_for_windows_workflow branch October 22, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci A feature or issue related to the continous integration tools windows A windows-specific issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants