[regression] The downgrade of cmake in the Windows image breaks downloading files

[townsend2010]

Description

After the recent downgrade of cmake from version 3.27.6 to 3.26.4 in the Windows runner image, downloading file archives is now broken. Here is the log snippet of the now breaking download:

2023-10-18T19:23:12.7819990Z -- Downloading from https://storage.googleapis.com/grpc-bazel-mirror/github.com/census-instrumentation/opencensus-proto/archive/v0.3.0.tar.gz, if failed, please try configuring again
2023-10-18T19:23:13.4735435Z CMake Error at build/_deps/grpc-src/cmake/download_archive.cmake:25 (file):
2023-10-18T19:23:13.4736483Z   file DOWNLOAD cannot compute hash on failed download
2023-10-18T19:23:13.4738523Z -- Downloading from https://github.com/census-instrumentation/opencensus-proto/archive/v0.3.0.tar.gz, if failed, please try configuring again
2023-10-18T19:23:13.4740301Z 
2023-10-18T19:23:13.4741100Z     status: [60;"SSL peer certificate or SSH remote key was not OK"]
2023-10-18T19:23:13.4742090Z Call Stack (most recent call first):
2023-10-18T19:23:13.4743299Z   build/_deps/grpc-src/CMakeLists.txt:376 (download_archive)
2023-10-18T19:23:13.4743818Z 
2023-10-18T19:23:13.4743824Z 
2023-10-18T19:23:13.4914592Z CMake Error at build/_deps/grpc-src/cmake/download_archive.cmake:25 (file):
2023-10-18T19:23:13.4915798Z   file DOWNLOAD cannot compute hash on failed download
2023-10-18T19:23:13.4916473Z 
2023-10-18T19:23:13.4916969Z     status: [60;"SSL peer certificate or SSH remote key was not OK"]
2023-10-18T19:23:13.4917814Z Call Stack (most recent call first):
2023-10-18T19:23:13.4918686Z   build/_deps/grpc-src/CMakeLists.txt:385 (download_archive)

Thank you for looking into this.

Platforms affected

• Azure DevOps
• GitHub Actions - Standard Runners
• GitHub Actions - Larger Runners

Runner images affected

• Ubuntu 20.04
• Ubuntu 22.04
• macOS 11
• macOS 12
• macOS 13
• Windows Server 2019
• Windows Server 2022

Image version and build link

20231016.1.0

Is it regression?

Yes, the last version that didn't exhibit this was 20231002.1.0.

Expected behavior

I expect the file(DOWNLOAD ...) to complete successfully.

Actual behavior

The download fails as pointed out in the log snippet above.

Repro steps

N/A

[townsend2010]

For a bit more context, here is the cmake function that is breaking:

  file(DOWNLOAD ${url} ${_TEMPORARY_FILE}
       TIMEOUT 60
       EXPECTED_HASH SHA256=${hash}
       TLS_VERIFY ON)

[sergei-pyshnoi]

Hello @townsend2010 , we will take a look.

[vpolikarpov-akvelon]

Hey, @townsend2010. The root cause of cmake downgrade is actually recent update of Strawberry Perl. It's now shipped with cmake that stands in PATH before standalone one. You can workaround it in your pipeline by fixing PATH value:

- name: Remove Strawberry Perl from PATH
  run: |
    $env:PATH = $env:PATH -replace "C:\\Strawberry\\c\\bin;", "" 
    "PATH=$env:PATH" | Out-File -FilePath $env:GITHUB_ENV -Append

As for long-term solution, we are looking for it.

[townsend2010]

Hi @vpolikarpov-akvelon!

Thanks for the response! I'll give your workaround a try in our workflow.

[townsend2010]

Just to confirm, the proposed workaround does indeed fix it for us. I now see cmake version 3.27.7 being used and no more errors during configuration. I will keep watching this issue for the "real" fix so we can back out the workaround at the appropriate time, but at least we are unblocked now. Thanks!

[TheLavaBlock]

we have the same problem in liblava - and we prefer to wait for it to be upgraded again.

[mikhailkoliada]

Deployed