Don't auto-restart processes which crash #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If supervisor instantly restarts a crashed process, it can be hard to notice. As we're in heavy development, it's far better to have a clear signal that a process has crashed (and is clearly shown in the output of supervisor.sh status) Also update the log filenames slightly to be consistent with the supervisor process names. (I.e. ad2-21:bs2-21-1 will now log to bs2-21-1.log, and not bs-2-21-1.log).
pszal
added a commit
that referenced
this pull request
Apr 27, 2015
Don't auto-restart processes which crash
chaehni
pushed a commit
to chaehni/scion
that referenced
this pull request
Jan 8, 2021
* Allow a second call to initQUICSockets. Force the port to zero before the second call. * use a parameter to ignore the port * fix comment
juagargi
added a commit
to juagargi/scion
that referenced
this pull request
Oct 5, 2021
Squashed changes for DRKey, ported to latest upstream master branch. This includes the following main commits: * 707a5e6 DRKey ported from the old SCIONLab (scionproto#77) This is itself a squashed commit containing the bulk of the newly added DRKey implementation. * 5a623a2 Allow a second call to initQUICSockets. (scionproto#79) * df3a258 unify personal annotations to JordiSubira (scionproto#80) * 9380c76 fix Level 1 key Exchange (scionproto#81) Add sanity check in the drkey_fetcher which validates that the response srcIA matches the intended server IA. * a90f354 Remove redundant fields from Lvl1Req/Resp (scionproto#83) * 64f4c23 cs/drkey: handle situations where no path to a peer AS can be found (scionproto#90) This condition is now handled analog to a similar condition in github.com/scionproto/scion/go/pkg/trust.AuthRouter.ChooseServer The main change applied to make this compatible with the master branch was to resolve the renaming / moving of what was previously pkg/sciond to now pkg/daemon. Co-authored-by: JordiSubira <jordi.subira.nieto@gmail.com> Co-authored-by: Juan A. Garcia Pardo <juagargi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If supervisor instantly restarts a crashed process, it can be hard to
notice. As we're in heavy development, it's far better to have a clear
signal that a process has crashed (and is clearly shown in the output of
supervisor.sh status)
Also update the log filenames slightly to be consistent with the
supervisor process names. (I.e. ad2-21:bs2-21-1 will now log to
bs2-21-1.log, and not bs-2-21-1.log).
@pszalach @rev112