Skip to content

Commit

Permalink
unify personal annotations to JordiSubira (scionproto#80)
Browse files Browse the repository at this point in the history
Only comments modified.
  • Loading branch information
JordiSubira authored Jan 12, 2021
1 parent 5a623a2 commit df3a258
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion go/pkg/cs/drkey/grpc/lvl1_exchange_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func TestLvl1KeyFetching(t *testing.T) {
require.NoError(t, err)
}

// XXX(jordiSubira) TestLvl1KeyFetching below checks correct Lvl1 key exchange as from Go1.15
// XXX(JordiSubira) TestLvl1KeyFetching below checks correct Lvl1 key exchange as from Go1.15
// which introduces VerifyConnection callback to access TLS state during handshake.

// func TestLvl1KeyFetching(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion go/pkg/cs/drkey/prefetcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var _ periodic.Task = (*Prefetcher)(nil)
type Prefetcher struct {
LocalIA addr.IA
Store drkeystorage.ServiceStore
// XXX(jonieto): At the moment we assume "global" KeyDuration, i.e.
// XXX(JordiSubira): At the moment we assume "global" KeyDuration, i.e.
// every AS involved uses the same EpochDuration. This will be improve
// further in the future, so that the prefetcher get keys in advance
// based on the epoch established by the AS which derived the first
Expand Down
2 changes: 1 addition & 1 deletion go/pkg/cs/drkey/secret_value_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (

// SecretValueStore keeps the current and next secret values and removes the expired ones.
type SecretValueStore struct {
// TODO(jordiSubira): simplify class to be more consistent with keeping current and next
// TODO(JordiSubira): simplify class to be more consistent with keeping current and next
// secret values.
cache map[int64]drkey.SV
mutex sync.Mutex
Expand Down
4 changes: 2 additions & 2 deletions go/pkg/trust/transport_credentials.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import (
"github.com/scionproto/scion/go/lib/serrors"
)

// XXX(jordiSubira): ClientCredentials enables hooking a procedure to validate
// XXX(JordiSubira): ClientCredentials enables hooking a procedure to validate
// the TLS state during the client handshake. Note that the current implementation
// extends the grpc/credentials callback for TLS credentials by carrying out the
// validation after the handshake has been completed (this last using the provided
Expand Down Expand Up @@ -69,7 +69,7 @@ func (c *ClientCredentials) ClientHandshake(ctx context.Context, authority strin
"authInfoType", authInfo.AuthType()),
}
}
// XXX (jonito): In Go1.13 tls.ConnectionState.ServerName is only set
// XXX (JordiSubira): In Go1.13 tls.ConnectionState.ServerName is only set
// on the server side. Thus, we pass authority as the serverName.
if err = verifyConnection(tlsInfo.State, authority); err != nil {
conn.Close()
Expand Down

0 comments on commit df3a258

Please sign in to comment.