Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API refactoring #94

Merged
merged 3 commits into from
Jun 19, 2024
Merged

API refactoring #94

merged 3 commits into from
Jun 19, 2024

Conversation

tzaeschke
Copy link
Collaborator

Clean up API:

  • Return ScionSocketAddress
  • Deduplicate address info ScionScoketAddress <-> path
  • Remove ResponseAddress type from API
  • ....

@tzaeschke tzaeschke self-assigned this Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Files Coverage Δ Complexity Δ
src/main/java/org/scion/jpan/Path.java 64.28% <100.00%> (+1.78%) 6.00 <4.00> (+1.00)
...main/java/org/scion/jpan/ScionDatagramChannel.java 82.72% <100.00%> (ø) 24.00 <0.00> (ø)
.../main/java/org/scion/jpan/ScionDatagramSocket.java 54.96% <100.00%> (-0.18%) 57.00 <0.00> (ø)
.../scion/jpan/internal/SelectingDatagramChannel.java 83.33% <100.00%> (ø) 8.00 <0.00> (ø)
...c/main/java/org/scion/jpan/ScionSocketAddress.java 87.50% <87.50%> (ø) 4.00 <4.00> (?)

@tzaeschke tzaeschke merged commit 35d1a44 into master Jun 19, 2024
9 checks passed
@tzaeschke tzaeschke deleted the fix/94-API-renaming branch June 19, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant