Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathSocketAddress #69

Closed
wants to merge 3 commits into from
Closed

PathSocketAddress #69

wants to merge 3 commits into from

Conversation

tzaeschke
Copy link
Collaborator

Make Path a subclass of InetSocketAddress

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 83.47107% with 20 lines in your changes missing coverage. Please review.

Files Coverage Δ Complexity Δ
.../main/java/org/scion/jpan/ScionDatagramSocket.java 56.10% <100.00%> (+1.31%) 56.00 <0.00> (-1.00) ⬆️
src/main/java/org/scion/jpan/ScmpChannel.java 84.30% <100.00%> (+0.09%) 18.00 <0.00> (ø)
.../java/org/scion/jpan/internal/HostsFileParser.java 86.88% <100.00%> (-0.22%) 18.00 <0.00> (ø)
...ava/org/scion/jpan/internal/ScionHeaderParser.java 77.16% <100.00%> (+0.27%) 34.00 <2.00> (ø)
.../scion/jpan/internal/SelectingDatagramChannel.java 83.33% <100.00%> (ø) 8.00 <0.00> (ø)
...n/java/org/scion/jpan/AbstractDatagramChannel.java 84.27% <91.66%> (+0.06%) 79.00 <1.00> (+2.00)
src/main/java/org/scion/jpan/Path.java 90.00% <85.71%> (+13.07%) 6.00 <5.00> (+1.00)
src/main/java/org/scion/jpan/RequestPath.java 45.71% <75.00%> (+0.12%) 11.00 <3.00> (ø)
src/main/java/org/scion/jpan/ResponsePath.java 73.33% <50.00%> (-11.29%) 6.00 <2.00> (ø)
src/main/java/org/scion/jpan/ScionService.java 71.61% <60.00%> (+0.54%) 53.00 <4.00> (+3.00)
... and 2 more

... and 2 files with indirect coverage changes

@tzaeschke tzaeschke force-pushed the fix/69-PathSocketAddress branch 3 times, most recently from 7d0d008 to d10cac2 Compare May 29, 2024 14:41
@tzaeschke
Copy link
Collaborator Author

Closed. Refactoring was implemented in #94 & #95

@tzaeschke tzaeschke closed this Jun 21, 2024
@tzaeschke tzaeschke deleted the fix/69-PathSocketAddress branch June 21, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant