Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename some scripts #878

Merged
merged 4 commits into from
Jan 22, 2024
Merged

rename some scripts #878

merged 4 commits into from
Jan 22, 2024

Conversation

arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Jan 16, 2024

Quick description

Rename scripts:

  • scil_detect_dwi_volume_outliers.py -> scil_dwi_detect_volume_outliers.py

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore requested a review from frheault January 16, 2024 19:50
@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore changed the title [WIP] rename some scripts rename some scripts Jan 22, 2024
@arnaudbore arnaudbore merged commit dbebda3 into scilus:master Jan 22, 2024
5 checks passed
@arnaudbore arnaudbore deleted the rename_scripts branch January 30, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants