[ENH] Add pull request template #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVCaron
requested changes
Jan 11, 2024
| - [ ] My changes generate no new warnings | ||
| - [ ] I moved all functions from the script file (except the argparser and main) to scilpy modules | ||
| - [ ] I have added tests that prove my fix is effective or that my feature works | ||
| - [ ] New and existing unit tests pass locally with my changes |
There was a problem hiding this comment.
This means we have to document running tests better. Especially how to scope which tests to run, where to check for logs, warnings, coverage, etc.
There was a problem hiding this comment.
We'll see later, this template is there as a reminder of everything that has to be done when you submit a PR.
Don't need to over think this right now, I think.
|
Build passed ! Good Job 🍻 ! |
|
Build passed ! Good Job 🍻 ! |
AntoineTheb
approved these changes
Jan 12, 2024
EmmaRenauld
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.