Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename volume scripts #829

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Conversation

arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Dec 4, 2023

scil_apply_transform_to_image.py - > scil_volume_apply_transfo.py
scil_count_non_zero_voxels.py -> scil_volume_count_non_zero_voxels.py
scil_crop_volume.py -> scil_volume_crop_.py
scil_flip_volume.py -> scil_volume_flip.py
scil_image_math.py -> scil_volume_math.py
scil_remove_outliers_ransac.py -> scil_volume_remove_outliers_ransac.py
scil_resample_volume.py -> scil_volume_resample.py
scil_reshape_to_reference.py -> scil_volume_reshape_to_reference.py
scil_snr_in_roi.py -> scil_dwi_compute_snr.py

@pep8speaks
Copy link

pep8speaks commented Dec 4, 2023

Hello @arnaudbore, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-12-04 22:07:48 UTC

@arnaudbore arnaudbore requested a review from frheault December 4, 2023 22:39
@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

Copy link
Contributor

@karanphil karanphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a small error in a legacy script. Not sure if volume should be replaced with image to have like scil_image_flip_volume.py or create the volume module instead of the volume_operations in the image module. Also, I understand the name scil_dwi_compute_snr.py, but it imports nothing from dwi.

scripts/legacy/scil_reshape_to_reference.py Outdated Show resolved Hide resolved
@EmmaRenauld
Copy link
Contributor

Spotted a small error in a legacy script. Not sure if volume should be replaced with image to have like scil_image_flip_volume.py or create the volume module instead of the volume_operations in the image module.

I think we prefer volume everywhere. It's clearer than image, which could be a picture. Do we want to change the image module to volume?

Also, I understand the name scil_dwi_compute_snr.py, but it imports nothing from dwi.

Indeed, the compute_snr function should go in dwi. It is now in volume_operations. But it takes as input the dwi, bval, bvec, so it is not appliable to any volume.

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit 1c13bb5 into scilus:master Dec 5, 2023
5 checks passed
@frheault
Copy link
Member

Has anyone ever used scil_volume_remove_outliers_ransac?

@arnaudbore arnaudbore deleted the rename_image_scripts branch January 30, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants