Rename connectomics and deprecate old #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @EmmaRenauld, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-12-04 16:10:10 UTC |
|
Build passed ! Good Job 🍻 ! |
1 similar comment
|
Build passed ! Good Job 🍻 ! |
EmmaRenauld
force-pushed
the
rename_connectomics
branch
from
30285b2 to
336baf2
Compare
|
Build passed ! Good Job 🍻 ! |
1 similar comment
|
Build passed ! Good Job 🍻 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scil_print_connectivity_filenames --> scil_connectivity_print_filenames
scil_compare_connectivity --> scil_connectivity_compare_populations
scil_compute_connectivity --> scil_connectivity_compute_matrices
scil_reorder_connectivity --> scil_connectivity_reorder_rois
scil_evaluate_connectivity_graph_measures --> scil_connectivity_graph_measures
scil_evaluate_connectivity_pairwise_agreement_measures --> scil_connectivity_pairwise_agreement
scil_normalize_connectivity --> scil_connectivity_normalize
scil_connectivity_math (already ok)
scil_filter_connectivity --> scil_connectivity_filter
NOT CHANGED:
scil_decompose_connectivity ---> It is NOT a connectivity script. It splits a tractogram into bundles (+ preprocessing and cleaning). There is possibly a LOT of overlap with stuff like scil_score_tractogram. To be cleaned.
@frheault We need to manage that some day if you have time to meet with me.
scil_save_connections_from_hdf5 --> The follow-up script.