Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF - Tracking/Tractogram Scripts #815

Merged
merged 12 commits into from
Nov 29, 2023

Conversation

gabknight
Copy link
Contributor

@gabknight gabknight commented Nov 24, 2023

@arnaudbore @AlexVCaron @mdesco I renamed a bunch of tracking related scripts following our discussion and @AlexVCaron PR. What do you think?

There are only documentation changes in the scripts themselves. File changes are the tests and the new legacy scripts.


  • scil_add_tracking_mask_to_pft_maps → scil_tracking_pft_maps_edit
  • scil_compute_local_tracking_dev → scil_tracking_local_dev
  • scil_compute_local_tracking → scil_tracking_local
  • scil_compute_maps_for_particle_filter_tracking → scil_tracking_pft_maps
  • scil_compute_pft → scil_tracking_pft

  • scil_apply_trandform_to_tractogram → scil_tractogram_apply_transform
  • scil_filter_tractogram → scil_tractogram_filter
  • scil_flip_streamlines → scil_tractogram_flip
  • scil_register_tractogram → scil_tractogram_register
  • scil_resample_tractogram → scil_tractogram_resample
  • scil_shuffle_streamlines → scil_tractogram_shuffle
  • scil_split_tractogram → scil_tractogram_split

@arnaudbore arnaudbore self-requested a review November 24, 2023 18:15
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@gabknight gabknight changed the title WIP/RF - Tracking/Tractogram Scripts RF - Tracking/Tractogram Scripts Nov 24, 2023
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

2 similar comments
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor

Everything seem perfect, can you modify associated docs. (docs/source/tractogram_registration.rst)

@gabknight
Copy link
Contributor Author

yes, thanks!

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit c25ca39 into scilus:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants