scil_merge_json move function into module #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @arnaudbore, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-11-17 15:44:24 UTC |
|
Build passed ! Good Job 🍻 ! |
EmmaRenauld
reviewed
Nov 7, 2023
scripts/scil_merge_json.py
Outdated
| return new_dict | ||
|
|
||
| return dict_1 | ||
| from scilpy.tractanalysis.json_utils import _merge_dict, _average_dict |
There was a problem hiding this comment.
About the names: I was trying to keep the convention that functions with _ are only reused in another function, not called in script. (And I don't add unit tests for these functions).
Are they worth renaming merge_dict and average_dict?
|
Build passed ! Good Job 🍻 ! |
1 similar comment
|
Build passed ! Good Job 🍻 ! |
|
Build passed ! Good Job 🍻 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next one will be: scil_convert_json_to_xlsx.py
I need some approval about the name of new module and the doc @frheault