Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple input to merge (for PR in connectoflow) #761

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

frheault
Copy link
Member

@frheault frheault commented Oct 9, 2023

I dont know what happened, but a PR got lost.

This connectoflow PR cannot work without this scilpy PR
https://github.com/scilus/connectoflow/pull/21/files

Simply load multiple tractograms to merge them in memory rather than merging them using scil_tractogram_math.py

@pep8speaks
Copy link

pep8speaks commented Oct 9, 2023

Hello @frheault, Thank you for updating !

Line 287:80: E501 line too long (80 > 79 characters)

Comment last updated at 2023-10-25 01:00:15 UTC

@arnaudbore arnaudbore self-requested a review October 9, 2023 17:26
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore self-requested a review October 25, 2023 01:38
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit 1237463 into scilus:master Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants