Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi centro labels map #728

Merged
merged 8 commits into from
Jun 29, 2023
Merged

Conversation

frheault
Copy link
Member

Update and simplification of the compute bundle voxel labels map.

  • Removal of the 2 parameters that no one uses (to trim streamlines) and that were a headache.
  • Switch from memmap to compute distances to a much faster/smarter kdtree
  • Fix a corner case of scil_project_streamlines.py

Now scil_compute_bundle_voxel_label_map.py support multi-centroids input to better handle complex fanning, but see be somewhat reliable. However, the full complexity of centroids' design is still an open question. As of now, it is still only an option and the default remains the same.

Tested with the last commit of scilus/tractometry_flow#18

@arnaudbore arnaudbore self-requested a review June 22, 2023 20:09
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit 4d37896 into scilus:master Jun 29, 2023
@frheault frheault deleted the multi_centro_labels_map branch February 28, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants