Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding import matplotlib to assign_custom_color_to_tractogram #713

Merged
merged 1 commit into from
May 2, 2023
Merged

Adding import matplotlib to assign_custom_color_to_tractogram #713

merged 1 commit into from
May 2, 2023

Conversation

karanphil
Copy link
Contributor

@karanphil karanphil commented Apr 24, 2023 •
edited
Loading

Somehow import matplotlib.pyplot as plt was removed from the scil_assign_custom_color_to_tractogram.py script, so the save_colorbar function did not work. I guess that the colorbar option is rarely used so that went under the radar...

Fixed it!

@frheault

CHrlS98
CHrlS98 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@CHrlS98 CHrlS98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed!

@arnaudbore arnaudbore self-requested a review April 24, 2023 17:45
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit bb09a96 into scilus:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CHrlS98 CHrlS98 CHrlS98 approved these changes

@arnaudbore arnaudbore Awaiting requested review from arnaudbore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karanphil @arnaudbore @CHrlS98