Fixing warning always showing up. #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaRenauld
force-pushed
the
fix_warning
branch
from
774e667 to
0e55403
Compare
|
Build passed ! Good Job 🍻 ! |
1 similar comment
|
Build passed ! Good Job 🍻 ! |
arnaudbore
reviewed
Mar 16, 2023
Co-authored-by: arnaudbore <arnaud.bore@gmail.com>
Co-authored-by: arnaudbore <arnaud.bore@gmail.com>
|
Build passed ! Good Job 🍻 ! |
1 similar comment
|
Build passed ! Good Job 🍻 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set
sft.data_per_point = None, internally, this is converted to an empty PerArraySequenceDict. So checks ofif sft.data_per_point is not Noneare always triggered. Fixing.