Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no_empty in scil_remove invalid streamlines.py #657

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

frheault
Copy link
Member

@frheault frheault commented Dec 5, 2022

Tractometry-Flow was crashing if centroids have 0 streamlines because scil_remove_invalid_streamlines.py was saving empty files at the end of RBX-Flow.

A new --no_empty option will avoid this problem.

@frheault frheault force-pushed the no_empty_remove_invalid branch from e4739f6 to 6f6550f Compare December 5, 2022 20:30
@arnaudbore arnaudbore self-requested a review December 5, 2022 21:04
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit 3048629 into scilus:master Dec 20, 2022
@frheault frheault deleted the no_empty_remove_invalid branch February 28, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants